Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "PAS-536 | Add support for AuthenticatorDisplayName" #747

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

Tyrrrz
Copy link
Contributor

@Tyrrrz Tyrrrz commented Oct 2, 2024

Reverts #713

@Tyrrrz Tyrrrz requested a review from a team as a code owner October 2, 2024 20:12
@Tyrrrz Tyrrrz enabled auto-merge (squash) October 2, 2024 20:12
Copy link

codecov bot commented Oct 2, 2024

Codecov Report

Attention: Patch coverage is 72.15909% with 49 lines in your changes missing coverage. Please review.

Project coverage is 35.18%. Comparing base (9514b52) to head (08b2225).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...dminConsole/Components/Shared/Credentials.razor.cs 0.00% 36 Missing ⚠️
src/Service/Fido2Service.cs 87.64% 10 Missing and 1 partial ⚠️
...vice/Migrations/Mssql/MsSqlContextModelSnapshot.cs 0.00% 1 Missing ⚠️
...ce/Migrations/Sqlite/SqliteContextModelSnapshot.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #747      +/-   ##
==========================================
- Coverage   35.58%   35.18%   -0.41%     
==========================================
  Files         584      579       -5     
  Lines       32227    31277     -950     
  Branches      899      898       -1     
==========================================
- Hits        11469    11005     -464     
+ Misses      20613    20129     -484     
+ Partials      145      143       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tyrrrz Tyrrrz merged commit 171be05 into main Oct 3, 2024
16 checks passed
@Tyrrrz Tyrrrz deleted the revert-713-auth-display-name branch October 3, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants